Rename some function to avoid name clash #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmarty
added
the
Record-Screenshots
github-actions
bot
removed
the
Record-Screenshots
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3705 +/- ##
========================================
Coverage 83.02% 83.02%
========================================
Files 1752 1752
Lines 43780 43772 -8
Branches 5121 5121
========================================
- Hits 36347 36341 -6
+ Misses 5612 5610 -2
Partials 1821 1821 ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is printing out warning during the generation of the gallery, such as:
Check for screenshots name duplication... Duplicated screenshot name: SheetContent - features.messages.impl.timeline.components.reactionsummary_SheetContent - features.messages.impl.actionlist_SheetContent Warning: 1 duplicated screenshot name(s) foundSecond commit fix the existing issue.
The problem is visible (for now) in the gallery at https://element-hq.github.io/element-x-android/?a=1&w=100&l=de%2Cfr#SheetContent. (make sure to check
Show all screenshots).2 unrelated screens was in the same table section:
This change will also give better title to those 2 screens in the gallery